-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Music mod causing crash with null object #99
Comments
https://gist.github.com/FreeFull/bd6bfa1610f559734c451e7393388391 Here are my logs for the same crash |
what version of bliss did you use i got the same crash with bliss 1.0.1 try for now till he fixed it turingin off music triggers mod
atleast you can play it but not at fill experiance till he fix it ;) |
i think i had kind of the same crash with the music trigger mod |
I also had the very same issue; I reported it on the mod's issues page here, though thought it was important also to mention it here. |
Szunakabeats |
the issue appears to be localized to this file https://github.com/TheComputerizer/Music-Triggers/blob/main/src/main/java/mods/thecomputerizer/musictriggers/client/MusicPlayer.java#L439 at the specified line. Could be hotfixed by placing a try catch block and setting variables fadingOut, tempFadeOut, and saveVolOut to some default values in the case of a catch. This wont fix the underlying problem, as far as I can tell there must be some combination of control flow that results in this code block running when volumeLinker has a null value. As far as I can tell, this should only happen if either said control flow occurred at the exact moment the file was run, or this: https://github.com/TheComputerizer/Music-Triggers/blob/main/src/main/java/mods/thecomputerizer/musictriggers/config/ConfigToml.java confusingly named file returned a null value in some of its saved maps, which all appear to be tracking various bits of data. (misclicked the close button when I commented this. Such a spazz.) |
why wontfix? |
It's outside the pack's scope. I'm just waiting on the music triggers update as much as all of you are |
crash-2022-05-31_08.23.56-client.txt
crash-2022-05-31_09.13.29-client.txt
crash-2022-05-31_08.07.06-client.txt
Sadly as I'm not too familiar with minecraft's code the most information I can give is what can be gathered by a cursory view of the crash report- however I shall still include it.
Issue appears to be a null variable contained in a map object that is being used by the music controller mod.
Pack was downloaded from curseforge, Vazkii has helpfully noted the crash appears to be caused by the music mod while unpausing.
The text was updated successfully, but these errors were encountered: