Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning particle effect is broken #3097

Open
ToMe25 opened this issue Jan 2, 2020 · 7 comments · May be fixed by #4710
Open

Lightning particle effect is broken #3097

ToMe25 opened this issue Jan 2, 2020 · 7 comments · May be fixed by #4710
Labels
bug A bug confirmed The maintainers will take a look at this. help-wanted Patches are wanted for this issue. Please drop us a note on Discord as well.

Comments

@ToMe25
Copy link
Contributor

ToMe25 commented Jan 2, 2020

Version Information

Forge version: 28.1.107
Botania version: r1.11-373

Steps to reproduce:

  1. get a filled mana pool
  2. drop an empty mana tablet into it

What I expected to happen: I expected to seed the lightnight like charging animation.

What happened instead: It charged the mana tablet without an animation.

@williewillus williewillus changed the title No charging animation for mana storing items in mana pools Lightning particle effect is broken Jan 3, 2020
@williewillus williewillus added bug A bug confirmed The maintainers will take a look at this. labels Jan 3, 2020
@williewillus williewillus added the help-wanted Patches are wanted for this issue. Please drop us a note on Discord as well. label Mar 8, 2020
@williewillus
Copy link
Member

Adding help-wanted: The old lightning effect rendering code is legacy garbage ripped from WRCBE.
I'd like someone to help rewrite it, preferably for 1.15.
There are resources online to generate lightning bolts (e.g. http://drilian.com/2009/02/25/lightning-bolts/, which is probably what wrcbe itself used) that you can read for the math.

@github-actions
Copy link

This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.

@artemisSystem
Copy link
Member

Wasn't this rewritten/changed, and the effect works now?

@williewillus
Copy link
Member

It works, but not fully. Some of the size and color params in the api call are ignored still I believe.

@Aegide
Copy link
Contributor

Aegide commented Jan 5, 2023

It seems like it works well enough in 1.19.2 (fabric).

image

Left: pool => tablet
Right: tablet => pool

@TheRealWormbo
Copy link
Collaborator

A valid point has been made on the forums:

If you transfer mana via spark, you get cool streaming particles, if you transfer it via spreader, you gear cool streaming particles, if you shoot it from a terra blade, you get cool shooting particles but when sparing mana to/from a pool with an item you get funky lightning. Why the inconsistency?

Why is the mana pool <-> item transfer animation this kind of slow lightning "non-particle"? The kind of wisp particles used for spark transfers (just a bit smaller, and between the surface of the pool and the apparent location of the item) might give a lot better of a feedback to players. The density of such particles could also be an indication of the transfer speed, especially when manatide bellows are involved, or unusual things like items overlapping multiple pools happen.

@artemisSystem
Copy link
Member

Fixed by #4710

@artemisSystem artemisSystem linked a pull request Oct 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug confirmed The maintainers will take a look at this. help-wanted Patches are wanted for this issue. Please drop us a note on Discord as well.
Development

Successfully merging a pull request may close this issue.

5 participants