Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI Dialog Safety and Responsiveness #5904

Open
3 of 7 tasks
bpotchik opened this issue Sep 5, 2024 · 0 comments
Open
3 of 7 tasks

Improve UI Dialog Safety and Responsiveness #5904

bpotchik opened this issue Sep 5, 2024 · 0 comments
Assignees
@bpotchik
Labels
Component: UI Issue needs changes to the user interface Effort: Medium Issue should take < 1 month Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps Type: Crash Issue is a crash or deadlock UI: Dialogs Issues with smaller dialogs

Comments

@bpotchik
Copy link
Member

bpotchik commented Sep 5, 2024 •
edited
Loading

There is a potential crash in the cancel path of several UI dialogs in the product. The affected dialogs are ones which kick off a background thread to perform some long running actions (e.g. retrieving symbols list). There is a race that can sometimes be lost allowing the background thread object to be deleted while the thread is still destructing resources.

The following dialogs need to be fixed:

  • AddressDialogWithPreview
  • AddUserXrefDialog
  • FindDialog
  • TypeDialog
  • CreateStructDialog
  • PreferencesDialog
  • NewTabWidget
@bpotchik bpotchik self-assigned this Sep 5, 2024
@bpotchik bpotchik added the Type: Crash Issue is a crash or deadlock label Sep 5, 2024
@xusheng6 xusheng6 added Type: Bug Issue is a non-crashing bug with repro steps Effort: Medium Issue should take < 1 month Impact: Medium Issue is impactful with a bad, or no, workaround Component: UI Issue needs changes to the user interface UI: Dialogs Issues with smaller dialogs labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpotchik bpotchik

Labels
Component: UI Issue needs changes to the user interface Effort: Medium Issue should take < 1 month Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps Type: Crash Issue is a crash or deadlock UI: Dialogs Issues with smaller dialogs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpotchik @xusheng6