Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C-SKY: ADDC and SUBC don't set the C to the carry bit after completion #5911

Open
fuzyll opened this issue Sep 9, 2024 · 0 comments
Open

C-SKY: ADDC and SUBC don't set the C to the carry bit after completion #5911

fuzyll opened this issue Sep 9, 2024 · 0 comments
Assignees
@emesare
Labels
Arch: C-SKY Issues with the C-SKY architecture plugin (Ultimate only) Component: Architecture Issue needs changes to an architecture plugin Edition: Ultimate Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps

Comments

@fuzyll
Copy link
Contributor

fuzyll commented Sep 9, 2024

Version and Platform (required):

  • Binary Ninja Version: 4.2.6025-dev Enterprise

Bug Description:
In C-SKY, the addc and subc instructions don't set the C to the carry bit after completion when lifting. It doesn't seem that the adc opcode provides a way to assign the carry bit somewhere, unless we're missing something.
@fuzyll fuzyll added Type: Bug Issue is a non-crashing bug with repro steps Component: Architecture Issue needs changes to an architecture plugin Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround Arch: C-SKY Issues with the C-SKY architecture plugin (Ultimate only) Edition: Ultimate labels Sep 9, 2024
@emesare emesare self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emesare emesare

Labels
Arch: C-SKY Issues with the C-SKY architecture plugin (Ultimate only) Component: Architecture Issue needs changes to an architecture plugin Edition: Ultimate Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fuzyll @emesare