Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Plugin]: binaryninja-ollama #274

Closed
1 task done
ahaggard2013 opened this issue Jul 11, 2024 · 9 comments
Closed
1 task done

[New Plugin]: binaryninja-ollama #274

ahaggard2013 opened this issue Jul 11, 2024 · 9 comments
Labels
new plugin Adding a new plugin

Comments

@ahaggard2013
Copy link

Plugin Description

Plugin to rename functions and variables with a locally hosted ollama server. Can use any of the openly available models such as llama3 and gemma2.

Plugin Repository URL

Repo URL: https://github.com/ahaggard2013/binaryninja-ollama

Real Release

  • I have made a real release
@ahaggard2013 ahaggard2013 added the new plugin Adding a new plugin label Jul 11, 2024
@ahaggard2013
Copy link
Author

read me was overwritten by release script, reposting

@psifertex
Copy link
Member

No worries, I have some other feedback i'm working on.

@psifertex
Copy link
Member

Here's my comments so far:

Thanks for the submission.

Should https://github.com/ahaggard2013/binaryninja-ollama/blob/main/ui.py#L28C43-L28C57 be updated to use 127.0.0.1 instead?

Also, please remove PySide6 in the requirements.txt as that is automatically provided by Binary Ninja if you first import binaryninjaui and then import PySide6. Otherwise you'll be getting whatever version of PySide6 Python installs which is likely to cause issues.

Alternatively, you could replace the UI code with interaction API calls so you don't have to write pyside at all.

Not important suggestion:
the documentation for functions is nice, but if you're going to do that you should really consider type hinting as it will help linters and IDEs make sure you code has less bugs in the future!

@ahaggard2013
Copy link
Author

thanks, fixed the ip/requirements, porting to interaction calls and type hinting will take a a bit more effort, but will look into it!

@negasora
Copy link
Member

Reopening this - please make a release with the requirements fixes

@negasora negasora reopened this Jul 12, 2024
@psifertex
Copy link
Member

TL;DR your latest code has the change to requirements, but not the latest release actually cut. This actually caused a user who installed the plugin to have all UI plugins break unfortunately so we've removed it from the plugin manager until it's resolved.

@ahaggard2013
Copy link
Author

ahaggard2013 commented Jul 14, 2024

whoops! I'm new to configuring releases and didn't release they weren't aligned, should be fixed now.

@psifertex
Copy link
Member

Thanks -- added back. Also, have you tried https://github.com/mrphrazer/reverser_ai ? I don't think I mentioned it before but it also uses an ollama model. Might be worth consolidating/merging any shared features, though Tim's plugin is GPLv2 so that could be an issue.

@ahaggard2013
Copy link
Author

ahaggard2013 commented Jul 15, 2024

I didn't see that plugin! That's awesome, very similar. I originally only saw the openai one which sparked the effort. I will have to give it a try later, looks like it has some cool additional features. Agreed on consolidation, I probably would have just worked off his version if I saw it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new plugin Adding a new plugin
Projects
None yet
Development

No branches or pull requests

3 participants