Bug Fixed - Bad Character Error : Invalid bad character detected.

[b3mb4m]

C:\Users\r00t\Desktop\Veil-Ordnance-master\Veil-Ordnance-master>python Veil-Ordnance.py -p rev_https --ip 192.168.63.149 --port 443 -e xor -b \x00

[*] Bad Character Error: Invalid bad character detected.
[*] Bad Character Error: Please provide bad characters in \x00\x01... format.

Ref : https://www.veil-framework.com/veil-ordnance-fast-shellcode-generation/

So .. after little research i figure out what's the problem.Problem is related "split" raw strings, when you split 'x' on badchar list will working like that;

bad_characters = bad_characters.split('x')
print bad_characters
//['\\', '00'] <-- backslash allways be there, that's the problem of fail.

I did change it like this and its work now,

bad_characters = bad_characters.split ("\\x")
bad_characters = bad_characters[1:]

-Tested on windows 7
-File : xor.py [line 70]

Cheers :)

[ChrisTruncer]

Hey,

First off, thanks for not only submitting a potential bug, but giving the fix. That's awesome! :)

I tried actually running the same command, and it completed for me without an error. I'm posting a screenshot here. So at the moment, I'm a little confused as to why you are getting an error because I can't get it to error out on my end at the moment.

[b3mb4m]

Yea i thought that was about windows.Or maybe python 2x, not sure.Did you try on windows ? Coz my test computer was w7.(Its working flawless now)

OS : Microsoft Windows 7 Ultimate
VER: 6.1.7601 Service Pack 1 Yapı 7601