-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors #3107
base: main
Are you sure you want to change the base?
Conversation
…t to the username.
import { GuildMember, User } from "discord-types/general"; | ||
|
||
const StreamerModeStore = findStoreLazy("StreamerModeStore"); | ||
const colorPattern = /^#(?:[\da-f]{3}){1,2}$|^#(?:[\da-f]{4}){1,2}$|(rgb|hsl)a?\((\s*-?\d+%?\s*,){2}(\s*-?\d+%?\s*)\)|(rgb|hsl)a?\((\s*-?\d+%?\s*,){3}\s*(0|(0?\.\d+)|1)\)$/iu; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be eaiser to just only allow an hex code as the color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps but it's already implemented and as far as I can tell quite robust and allows more freedom of input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would probably be eaiser if the user just passed a format string eg{username} ({nickname})
instead of having six settings for prefixes and suffixes
Updated to switch to a string format input instead of a drop down. |
Changes
Nick [DISPLAY] (@username)
Role+-#
input (ex:Role+15
) to set it to the role color brightened/darkened by that percentage. Falls back to Discord's default gray.@
sign from mentions (and replies) due to the possibility of it visually conflicting with the prefixes and suffixes.Ignore the branch name. I originally just planned to add streamer mode support before deciding to add more. (Also wasn't aware there was already a PR for that, oops.)This PR adds a ton of settings due to the customization but it's all quite straightforward and the default settings should serve most people fine in my opinion if they don't want to tinker with anything.
Examples