Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficiently handle doubles in ByteBuffer.getDouble/putDouble #3

Closed
niloc132 opened this issue Dec 5, 2019 · 1 comment
Closed

Efficiently handle doubles in ByteBuffer.getDouble/putDouble #3

niloc132 opened this issue Dec 5, 2019 · 1 comment

Comments

@niloc132
Copy link
Member

niloc132 commented Dec 5, 2019

Presently these values are read as long, and then converted to double - while this is technically correct, it is very inefficient in JS, since we have to emulate those long values.
@niloc132 niloc132 mentioned this issue Dec 11, 2019
Open
@niloc132
Copy link
Member Author

Fixed in a48b7c9 (sha subject to change if we prune history), related issue filed as #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niloc132