Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPIControl should use external binaries of GoodbyeDPI, instead of bundling them #5

Open
Amegatron opened this issue Aug 7, 2024 · 0 comments

Comments

@Amegatron
Copy link

Bundling GoodbyeDPI within this app can have potential issues:

  1. GoodbyeDPI may update independently from this app, which in turn will require corresponding updates (or at least just rebuilding) of this controll app.
  2. Having the binaries bundled within this app may potentially be a threat, because they are no longer open-sourced, and their origin may be unknown

So, from my point of view, it would be wiser to just reference external binaries of GoodbyeDPI from this app (in settings). Unless GoodbyeDPI's command line options ("interface") change, there should be no compatibility issues.

Virenbar added a commit that referenced this issue Aug 8, 2024
Will be needed for #5 in future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant