Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong grid settings in platform web interface #1609

Open
adminoren opened this issue Jul 18, 2019 · 2 comments
Open

Wrong grid settings in platform web interface #1609

adminoren opened this issue Jul 18, 2019 · 2 comments

Comments

@adminoren
Copy link
Contributor

BladesBug

Platform: 2.13.47

  1. Open a new blade which has different grid settings and change grid settings in that blade.
  2. Close new blade, click "Refresh" on the old blade. The grid in old blade with load settings of the previous blade.
    When we refresh data, Uigridutils uses bladeNavigationService.currentBlade to get settings of the grid. And when we close blade, bladeNavigationService.currentBlade points to the closed blade.
    It seems that the issue can be fixed in bladeNavigation.js:
if (blade.parentBlade && blade.parentBlade.isExpandable) {
                blade.parentBlade.isExpanded = true;
                if (angular.isFunction(blade.parentBlade.onExpand)) {
                    blade.parentBlade.onExpand();
                }
            }

Replace the above code with:

if (blade.parentBlade) {
	service.currentBlade = blade.parentBlade;
	if (blade.parentBlade.isExpandable){
		blade.parentBlade.isExpanded = true;
		if (angular.isFunction(blade.parentBlade.onExpand)) {
			blade.parentBlade.onExpand();
		}
	}}
@yecli
Copy link
Contributor

yecli commented Jul 24, 2019

There is a problem when we open couple of child blades (e.g. Catalog->Select category->Select product), and then click on some catalog in Catalog blade.
Video with catalog
You can see that because showing called before closing children service.currentBlade is assigned improperly - it is not opened categories blade, but the catalog one (which is the parent of blade closed last).

So we cannot apply this change now. Whether more changes needed here, or maybe you could try to solve the problem other way.

@tatarincev
Copy link
Contributor

This issue has been closed because it has been inactive for a long time
You may reopen this issue if it has been closed in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants