Replies: 2 comments 4 replies
-
Hi, I just pulled master into the branches because so much has been merged to master lately. I'm on branch ch-210312-raytrace-MC and when I build I get 2 warnings: Did I merge incorrectly? |
Beta Was this translation helpful? Give feedback.
2 replies
-
This has been implemented. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I've found, in creating the user samples, the utility of having extension method operators on
Range<T>
objects. The need to callmyRange.AsEnumerable().ToArray()
is unconcise and not very intuitive to newcomers. It will also be that much more confusing if we need to add any additional calls to make it compatible with PythonNet.In order to resolve these, I'd propose:
ToArray()
extension method in a newRangeExtensions
classThis would also clean up the code significantly throughout the codebase. Only check would be to ensure that any WPF databinding to a Range isn't disrupted by it newly implenting
IEnumerable<T>
(sometimes there are weird defaults, but this one is easy to check that databinding continues to work).Beta Was this translation helpful? Give feedback.
All reactions