Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long node names truncated #82

Open
m-emm opened this issue Feb 12, 2017 · 6 comments · May be fixed by #188
Open

Long node names truncated #82

m-emm opened this issue Feb 12, 2017 · 6 comments · May be fixed by #188

Comments

@m-emm
Copy link

m-emm commented Feb 12, 2017

In ontologies with a bit longer node names (longer that about 10 characters), the node names are truncated, and often the resulting graph is barely useable because of that.
This can be easily seen when looking at the FOAF ontology on the nodes "Online Account", "Online Chat Account", "Online E-commerce Account".

One possible solution might be to break camel case or spaced labels into multiple lines.

@steffen-l
Copy link
Contributor

Good point! We are aware of it, and it is already on our issue list. We will likely implement a similar solution as in LD-VOWL also for WebVOWL in the future: http://vowl.visualdataweb.org/ldvowl/ So this will likely be included in some future release. For now, you have the tooltips with the full name when you hover the element.

@handrews
Copy link

@steffen-l would you be receptive to pull requests? I didn't see a contributors' guide but perhaps I overlooked it somewhere. Not promising anything but I am really liking this tool and would like to help it along if I get a chance.

@steffen-l
Copy link
Contributor

Yes, we are generally fine with pull requests and will likely accept them (if we don't have any bigger objections). Just go ahead! Contributions are appreciated.

However, note that for this issue here ("long node names truncated"), we already implemented a solution in part that will soon be completed and pushed - likely before end of May).

@handrews
Copy link

@steffen-l great to hear on both counts. I'll hold off on this one and wait for the next release.

@imaneelarabi
Copy link

Is there any news on this?

@nandikajain
Copy link
Contributor

@steffen-l @vitalis-wiens
The issues arises here in src/webvowl/js/util/:

CenteringTextElement.prototype.addTextline = function ( text, style, prefix, postfix ){
  var truncatedText = textTools.truncate(text, this._textBlock().datum().textWidth(), style);
AbsoluteTextElement.prototype.addTextline = function ( text, style, yShift, prefix, postfix ){
  var truncatedText = textTools.truncate(text, this._textBlock().datum().textWidth(yShift), style);

Here, the text is truncated. If we split the text based on the white spaces and then add line breaks, that could possibly solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants