Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change to a custom gamemode in vanilla gamemodes' main #28

Open
DiskPoppy opened this issue Apr 7, 2022 · 1 comment
Open

Can't change to a custom gamemode in vanilla gamemodes' main #28

DiskPoppy opened this issue Apr 7, 2022 · 1 comment

Comments

@DiskPoppy
Copy link

I think uberasmtool still thinks it's a vanilla gamemode, so it uses the vanilla table and crashes.

@Fernap
Copy link

Fernap commented Apr 8, 2022

Presumably line 55 in asm/base/gamemode.asm should be changed to LDA !previous_mode rather than LDA $0100|!addr (haven't actually tested though). previous_mode has already been updated by that point, so it'll jump to the routine for the currently executing mode, rather than the mode that $0100 has been changed to.

That is, unless you want the current mode to be able to be overridden in this way, but that doesn't look like it's intended based on the way what's there is written.

Fernap pushed a commit to Fernap/UberASMTool that referenced this issue Dec 12, 2022
… switch to a custom game mode from a vanilla game mode's main routine (see VitorVilela7#28).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants