Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone Metamask integration #61

Closed
Kisgus opened this issue Dec 8, 2018 · 6 comments
Closed

Postpone Metamask integration #61

Kisgus opened this issue Dec 8, 2018 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@Kisgus
Copy link
Contributor

Kisgus commented Dec 8, 2018

This is a ✨ Cryptoxmas.xyz bounty✨

Every bounty DAI paid out will be matched as a donation to this Venezuelan Giveth Campaign

Userstory

As a user I want to be able to view Christmas Cards before being asked to login via metamask,
so that I can see the selection of images from a normal web2 browser.

Remove need to login to browse tokens

Requires

UI

Will be proposed by @seichris & @artyomignatyev

@Kisgus Kisgus added the help wanted Extra attention is needed label Dec 8, 2018
@seichris
Copy link
Collaborator

seichris commented Dec 8, 2018

Whats the difference to #31 ?

@Dobrokhvalov
Copy link
Contributor

They have different scopes. This one postpones connection to Metamask, #31 is for changing js libraries.
#31 is purely technical, doesn't have updates to the UI.
Having #31 implemented, we can start working on this one.

@seichris
Copy link
Collaborator

seichris commented Dec 9, 2018

So, in the UI there is 3 states, we have to "postpone" then.

How it could look

This includes three states:

  • Loading, because not signed
  • No Metamask installed
  • Wrong network

All three are postponed to "buy & send" screen.

@artyomignatyev what do you think? Do you think there should be a popup, or should this be fullscreen?

Loading

@Kisgus
Copy link
Contributor Author

Kisgus commented Dec 9, 2018

I think we also really need a better "network is not supported" network screen, anyhow knows a dapp thats follows best practice here?

@danfinlay
Copy link

FYI, you don't need to ask a user to open MetaMask to log in anymore, thanks to the new method ethereum.enable():
https://medium.com/metamask/eip-1102-preparing-your-dapp-5027b2c9ed76

@seichris
Copy link
Collaborator

seichris commented Dec 13, 2018

Thanks for the reminder @danfinlay . We are using ethereum.enable() already and hope we can update the UX on this flow in this issue, so web2 users actually can surf our NFTs.

@artyomignatyev i updated the figma screenshots above. Feedback welcome ;)

@Kisgus Kisgus closed this as completed Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants