diff --git a/src/main/java/com/vonage/client/HttpConfig.java b/src/main/java/com/vonage/client/HttpConfig.java index 25be50816..c19742d6a 100644 --- a/src/main/java/com/vonage/client/HttpConfig.java +++ b/src/main/java/com/vonage/client/HttpConfig.java @@ -79,18 +79,22 @@ public boolean isDefaultVideoBaseUri() { return DEFAULT_VIDEO_BASE_URI.equals(videoBaseUri); } + @Deprecated public String getVersionedApiBaseUri(String version) { return appendVersionToUri(apiBaseUri, version); } + @Deprecated public String getVersionedRestBaseUri(String version) { return appendVersionToUri(restBaseUri, version); } + @Deprecated public String getVersionedApiEuBaseUri(String version) { return appendVersionToUri(apiEuBaseUri, version); } + @Deprecated public String getVersionedVideoBaseUri(String version) { return appendVersionToUri(videoBaseUri, version); } diff --git a/src/test/java/com/vonage/client/HttpConfigTest.java b/src/test/java/com/vonage/client/HttpConfigTest.java index d4ec2f3db..64d2f8746 100644 --- a/src/test/java/com/vonage/client/HttpConfigTest.java +++ b/src/test/java/com/vonage/client/HttpConfigTest.java @@ -23,12 +23,22 @@ public class HttpConfigTest { static final String EXPECTED_DEFAULT_API_BASE_URI = "https://api.nexmo.com", EXPECTED_DEFAULT_REST_BASE_URI = "https://rest.nexmo.com", + EXPECTED_DEFAULT_API_EU_BASE_URI = "https://api-eu.vonage.com", + EXPECTED_DEFAULT_VIDEO_BASE_URI = "https://video.api.vonage.com", EXAMPLE_BASE_URI = "https://example.com"; static void assertDefaults(HttpConfig config) { assertEquals(60000, config.getTimeoutMillis()); + + assertTrue(config.isDefaultApiBaseUri()); + assertTrue(config.isDefaultRestBaseUri()); + assertTrue(config.isDefaultApiEuBaseUri()); + assertTrue(config.isDefaultVideoBaseUri()); + assertEquals(EXPECTED_DEFAULT_API_BASE_URI, config.getApiBaseUri()); assertEquals(EXPECTED_DEFAULT_REST_BASE_URI, config.getRestBaseUri()); + assertEquals(EXPECTED_DEFAULT_API_EU_BASE_URI, config.getApiEuBaseUri()); + assertEquals(EXPECTED_DEFAULT_VIDEO_BASE_URI, config.getVideoBaseUri()); } @Test @@ -42,6 +52,8 @@ public void testApiBaseUriOnly() { assertEquals(EXAMPLE_BASE_URI, config.getApiBaseUri()); assertEquals(EXPECTED_DEFAULT_REST_BASE_URI, config.getRestBaseUri()); + assertEquals(EXPECTED_DEFAULT_API_EU_BASE_URI, config.getApiEuBaseUri()); + assertEquals(EXPECTED_DEFAULT_VIDEO_BASE_URI, config.getVideoBaseUri()); } @Test @@ -50,11 +62,33 @@ public void testApiRestUriOnly() { assertEquals(EXPECTED_DEFAULT_API_BASE_URI, config.getApiBaseUri()); assertEquals(EXAMPLE_BASE_URI, config.getRestBaseUri()); + assertEquals(EXPECTED_DEFAULT_API_EU_BASE_URI, config.getApiEuBaseUri()); + assertEquals(EXPECTED_DEFAULT_VIDEO_BASE_URI, config.getVideoBaseUri()); + } + + @Test + public void testApiEuUriOnly() { + HttpConfig config = HttpConfig.builder().apiEuBaseUri(EXAMPLE_BASE_URI).build(); + + assertEquals(EXAMPLE_BASE_URI, config.getApiEuBaseUri()); + assertEquals(EXPECTED_DEFAULT_API_BASE_URI, config.getApiBaseUri()); + assertEquals(EXPECTED_DEFAULT_REST_BASE_URI, config.getRestBaseUri()); + assertEquals(EXPECTED_DEFAULT_VIDEO_BASE_URI, config.getVideoBaseUri()); + } + + @Test + public void testVideoUriOnly() { + HttpConfig config = HttpConfig.builder().videoBaseUri(EXAMPLE_BASE_URI).build(); + + assertEquals(EXAMPLE_BASE_URI, config.getVideoBaseUri()); + assertEquals(EXPECTED_DEFAULT_API_BASE_URI, config.getApiBaseUri()); + assertEquals(EXPECTED_DEFAULT_REST_BASE_URI, config.getRestBaseUri()); + assertEquals(EXPECTED_DEFAULT_API_EU_BASE_URI, config.getApiEuBaseUri()); } @Test public void testAllBaseUri() { - HttpConfig config = HttpConfig.builder().baseUri(URI.create(EXAMPLE_BASE_URI)).build(); + HttpConfig config = HttpConfig.builder().baseUri(URI.create(EXAMPLE_BASE_URI + '/')).build(); assertEquals(EXAMPLE_BASE_URI, config.getApiBaseUri()); assertEquals(EXAMPLE_BASE_URI, config.getRestBaseUri()); diff --git a/src/test/java/com/vonage/client/HttpWrapperTest.java b/src/test/java/com/vonage/client/HttpWrapperTest.java index c0b7f253e..ecf5ef6b7 100644 --- a/src/test/java/com/vonage/client/HttpWrapperTest.java +++ b/src/test/java/com/vonage/client/HttpWrapperTest.java @@ -20,11 +20,6 @@ import static org.junit.jupiter.api.Assertions.*; public class HttpWrapperTest { - private static final String - EXPECTED_DEFAULT_API_BASE_URI = "https://api.nexmo.com", - EXPECTED_DEFAULT_REST_BASE_URI = "https://rest.nexmo.com", - EXPECTED_DEFAULT_VIDEO_BASE_URI = "https://video.api.vonage.com"; - private HttpWrapper wrapper; @BeforeEach @@ -37,6 +32,11 @@ public void basicTest() { assertNotNull(wrapper.getHttpClient()); } + @Test + public void testGetApiKey() { + assertNull(wrapper.getApiKey()); + } + @Test public void testAuthMethodAccessors() { AuthCollection auths = new AuthCollection(); @@ -49,8 +49,5 @@ public void testDefaultConstructorSetsDefaultConfigValues() { HttpConfig config = wrapper.getHttpConfig(); assertNotNull(config); HttpConfigTest.assertDefaults(config); - assertEquals(EXPECTED_DEFAULT_API_BASE_URI, config.getApiBaseUri()); - assertEquals(EXPECTED_DEFAULT_REST_BASE_URI, config.getRestBaseUri()); - assertEquals(EXPECTED_DEFAULT_VIDEO_BASE_URI, config.getVideoBaseUri()); } } diff --git a/src/test/java/com/vonage/client/conversations/ConversationsClientTest.java b/src/test/java/com/vonage/client/conversations/ConversationsClientTest.java index ae9331dfd..12fb47ae9 100644 --- a/src/test/java/com/vonage/client/conversations/ConversationsClientTest.java +++ b/src/test/java/com/vonage/client/conversations/ConversationsClientTest.java @@ -96,7 +96,7 @@ public class ConversationsClientTest extends AbstractClientTest fromString("Newest")); + } }