Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-sync to Resx file on 2019 #8

Open
techcap opened this issue Apr 11, 2019 · 5 comments
Open

Auto-sync to Resx file on 2019 #8

techcap opened this issue Apr 11, 2019 · 5 comments

Comments

@techcap
Copy link

techcap commented Apr 11, 2019

On 2017, Auto-sync to Resx and Ico files function was really nice.
But I cannot find that kind of function on 2019. it generates only cs file not resx and ico files.
Is it replaced by other tools?

@madskristensen
Copy link
Collaborator

In VS 2019 using the latest 16.x version of Microsoft.VSSDK.BuildTools you no longer need the .resx/.ico files. That's why it no longer auto-creates them

@techcap
Copy link
Author

techcap commented Apr 12, 2019

When I changed vsixmanifest file, only ______1.cs file is generated in VS2019. Is it by design?
https://github.com/techl/MonoRemoteDebugger/blob/master/MonoRemoteDebugger.VSExtension/source.extension.vsixmanifest

@yannduran
Copy link
Contributor

@madskristensen How are we supposed to provide an image on the Help | About page now?

There's no new overload constructor for InstalledProductRegistration that I know of.

@madskristensen
Copy link
Collaborator

You'll have to do that manually by adding a .resx file and mark it with MergeWithCTO. It's a hassle to be honest. I've concluded that a logo in the Help/About dialog is pretty much useless. Very few people look at that list of components anyway and when they do, it's for troubleshooting reasons. So, not a prime location for an extension logo.

In light of that, i decided not to include it in the VSIX Synchronizer extension to keep things simple

@yannduran
Copy link
Contributor

Sorry, I didn't mean to imply that you had made a bad decision in Auto-sync to Resx file. I understand your reasoning completely.

I had just wondered, with the decision to remove the resx file in the async project templates, and no new provision in InstalledProductRegistration to provide an image to the attribute's constructor, without a resx file, what the thinking was going forward for addressing that consequence of removing it.

If you were involved in that decision, then although I don't agree with not having an easy way to add a logo without resorting to a resx file, I still do understand your reasoning. Other than the logo issue, I'm, actually glad to be rid of the resx file.

To me though, it feels unprofessional/lax to not have a logo there for when people actually do see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants