Month range picker doesn't trigger rangeStart rangeEnd events properly #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jllavec I appreciate the PR, however, instead of removing re-emit if the range order is changed, can you only correct the second |
|
Are welcome @Jasenkoo :) Glad to help! Is this an intended behavior for range month picker for any purpose? Just want to understand it, since as i checked, in range date picker, it doesn't behave like this. So that's why i replicated this behavior, as I wanted to show in the stackblitz that i provided in the issue #1005 . |
|
You are right, there is no need to emit again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I changed how events are triggered, because when end of range date selected is sooner than start of range date, it triggers range-start twice.
So now, i mantain the unshift in the array to have dates in proper order, but triggering range-end event since range selection is finished.
Issue ticket number and link
Fixes #1005
Checklist before requesting a review