Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change module folder naming convention to fit typeName instead of collectionName #158

Open
eric-burel opened this issue Jan 30, 2020 · 0 comments

Comments

@eric-burel
Copy link
Collaborator

Following discussion with @Neobii , using the plural collectionName is a source of complexity, discrepancies and even bugs.
Automatically computing the plural can give unexpected results (like "schema" > "schemata" instead of the more usual "schema") and even name clashes.

Instead, the typeName, singular should be preferred on many occasions. All the more that in the future we may have more and more GraphQL type not tied to a collection anyway.

This applies especially to directory names modules/movies > modules/movie.

We should take that into account during next updates, when we modify a package it's an occasion to also rename its directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant