Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example-forum emails still using pre-1.12 API #97

Open
jimrandomh opened this issue Oct 9, 2018 · 2 comments
Open

example-forum emails still using pre-1.12 API #97

jimrandomh opened this issue Oct 9, 2018 · 2 comments

Comments

@jimrandomh
Copy link

The Vulcan 1.12 migration guide (https://medium.com/@sachagreif/vulcan-js-1-12-a-better-graphql-api-for-crud-operations-fae82e03a7e9) describes some things that need to be done to make email sending work in 1.12. However, it looks like Vulcan-Starter/packages/example-forum/lib/modules/notifications/emails.js hasn't had the migration applied. I was hoping to look at that file to see an example of how the new email API works.

@SachaG
Copy link
Contributor

SachaG commented Oct 12, 2018

You're right, I don't have much time to work on that right now so hopefully someone can submit a PR. Here's an example from http://zenshome.jp using the new API:

https://gist.github.com/SachaG/1f1c50408aaa2ca4c43d3b27b34e2007

@lc3t35
Copy link

lc3t35 commented Nov 21, 2018

+1, please update documentation give some examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants