Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cache to Apollo v3 #2656

Open
eric-burel opened this issue Nov 4, 2020 · 2 comments
Open

Migrate cache to Apollo v3 #2656

eric-burel opened this issue Nov 4, 2020 · 2 comments
Labels
apollo next release Needed for next Vulcan release

Comments

@eric-burel
Copy link
Contributor

eric-burel commented Nov 4, 2020

Is your feature request related to a problem? Please describe.
We need to update Apollo client cache system to v3. The problem is that there is a breaking change, there is no fragment matcher anymore: https://www.apollographql.com/docs/react/migrating/apollo-client-3-migration/#breaking-cache-changes

End user must be able to provide "possibleTypes" instead.

Also, updating the cache directly lead to writeData is not defined for hooks optimistic update.

Describe the solution you'd like

  • should we compute possible types automatically? As long as we don't generate unions I think not
  • however we certainly need the user to be able to setup the possibleTypes for their app

So:

  1. Adding a new method to register some possible types? Pass them at client creation?
    (note that in Next we avoid such issues by letting the user create its own client ; creating it in Vulcan core is convenient but makes tweaking diffficult).
  2. remove apollo-cache-* deps when done
  3. replace cache "writeData" by writeQuery (as it is already done in Vulcan NPM: https://github.com/VulcanJS/vulcan-npm/blob/devel/packages/react-hooks/multiQueryUpdater.ts), this part will be easy

Additional context
https://www.apollographql.com/docs/react/migrating/apollo-client-3-migration/#breaking-cache-changes

@eric-burel eric-burel added good first issue apollo next release Needed for next Vulcan release and removed good first issue labels Nov 4, 2020
@ErikDakoda
Copy link
Contributor

I am seeing a lot of "Invariant Violation" errors from Apollo 3 in the browser console. They are not causing breaking errors, but they are an indication that the Apollo client cache is probably not operating efficiently.

So the point is that we need to move on this sooner rather than later.

In addition, there are other vestiges of Apollo 2 like apollo-link-state that we should probably deprecate from the Vulcan code (see apollographql/apollo-client#5982). In this case it's possible that nobody in Vulcan land is using link state - but how do we find that out? Is it safe to just remove this feature?

I could probably make these changes, but I can't commit to starting right away because of other deadlines I have. But if I do start on this, how do I make sure that no-one else is doing the same work? To discuss that question further, I will open another issue.

@eric-burel
Copy link
Contributor Author

eric-burel commented Jan 25, 2021

Contribution on Apollo v3 would be muuuch appreciated. If you start something, I would simply suggest releasing a patch version of Vulcan current code before we merge the work, and then release a minor.

It's ok to have breaking change, as long as we rely on semantic versioning. There is also a MIGRATING.md where you can explain breaking changes manually + the automated changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apollo next release Needed for next Vulcan release
Projects
None yet
Development

No branches or pull requests

2 participants