Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about callbacks #107

Open
Neobii opened this issue Dec 10, 2018 · 1 comment
Open

Add documentation about callbacks #107

Neobii opened this issue Dec 10, 2018 · 1 comment

Comments

@Neobii
Copy link
Contributor

Neobii commented Dec 10, 2018

When you add callbacks, it's unclear that the naming convention for collection hooks are being supplied in lower case which is different than the naming convention of the Type definition which is uppercase.

ie:

modifier = runCallbacks({ name: `movie.update.before`, iterator: data, properties: { document, currentUser }});

const Movies = createCollection({
  typeName: "Movie",

  schema,

  resolvers,

  mutations
});
@SachaG
Copy link
Contributor

SachaG commented Dec 15, 2018

Good point. I think ultimately we'll make callback names case-insensitive to avoid this issue altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants