You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Provide a clear and concise description of what you want to happen.
Docker build time is quite slow atm, in part due to playwright. Could we re-order docker build steps for smarter caching?
i.e. install playwright before the rest of the packages so that if we change one package we don't have to re-do these steps?
I looked into this a bit while working on #929, mostly by using caching in docker buildx.
Some steps would drop to much shorter build times (say 2s instead of 20+), but I never managed to get the entire chain to work correctly. playwright is annoying in that it expects to install the python package, and THEN to install the heavy stuff which is going to change less often.
What I would try:
figure out where the install-deps step of playwright caches its stuff, and see if we can mount it like here
if that doesn't work, we could figure out a way to do a multi-step docker build, where we build a first image with poetry+playwright and its dependencies, and then install the rest of python packages in the second build step. We'd have to look into poetry's options, but I think using group dependencies we could put playwright in an optional group, install only that, then its dependencies, then the rest of python packages.
Provide a clear and concise description of what you want to happen.
Docker build time is quite slow atm, in part due to playwright. Could we re-order docker build steps for smarter caching?
i.e. install playwright before the rest of the packages so that if we change one package we don't have to re-do these steps?
Thoughts @laurentS ?
Is there anything else you can add about the proposal? You might want to link to related issues here, if you haven't already.
No response
The text was updated successfully, but these errors were encountered: