Silence "converting a masked element to nan" warning #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded and deployed at https://prism-924.surge.sh |
JulienPathtech
approved these changes
Jul 26, 2023
api/app/utils.py
Outdated
| warning_recorded = False | ||
|
|
||
|
|
||
| def custom_warning_handler(message, category, filename, lineno, file=None, line=None): |
There was a problem hiding this comment.
I don't know if it's an issue for you, but https://docs.python.org/3/library/warnings.html#warnings.showwarning write to a file which is sys.stderr by default.
We could call the default _showwarnmsg_impl for messages we don't want to filter to be clother to existings behavior ?
There was a problem hiding this comment.
This is an intenal function and looks like it has different signature based on the pyhton version. I'll use a standard logger instead, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence "converting a masked element to nan" logs warnings after the first occurrence to avoid spamming the logs