Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly] failing linsolve test #159

Open
jpthiele opened this issue Nov 28, 2024 · 1 comment
Open

[Nightly] failing linsolve test #159

jpthiele opened this issue Nov 28, 2024 · 1 comment
Labels
julia nightly Issues that need fixing to support the upcoming julia release upstream bug A bug caused by dependencies/upstream code

Comments

@jpthiele
Copy link
Contributor

The nightly workflow fails on the 'linsolve' test.
It issues a bunch of warnings about LLVM calls with integer pointers being deprecated.
I suppose this leads to the wrong comparison result in the end.

However, all the warnings are issues for upstream packages like LoopVectorization or LinearSolve.

@j-fu what is the best way forward, should I open some issues to make the upstream package maintainers aware?

@jpthiele jpthiele added upstream bug A bug caused by dependencies/upstream code julia nightly Issues that need fixing to support the upcoming julia release labels Nov 28, 2024
@j-fu
Copy link
Member

j-fu commented Nov 28, 2024

The failing test is about allocation behavior. The integer pointer stuff are just warnings
which might go away with newer versions of nightly.

So these IMHO are essentially two issues.

I think it is worth to open an issue (probably in RecursiveFactorizations.jl), but not without an MWE and a bit of furher investigation. And we would need to look for already open issues/PRs relevant to this.

For context (note to self: document the test): it is about having a non-allocating inplace LU factorization for generic number types (including ForwardDiff.Dual). With mixture flows, I want to solve the Stefan-Maxwell ansatz to obtain fluxes from their implicit description in each flux function call.

RecursiveFactorizations.jl provides this. But it depends on LoopVectorization.jl whose fate is a bit brittle.

I have my own (albeit non-pivoting) implementation based on the Doolittle LU algorithm as a fallback. See vfvm_functions.jl which may be good enough.

Also, may be now there are more alternatives available besides RecursiveFactorizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
julia nightly Issues that need fixing to support the upcoming julia release upstream bug A bug caused by dependencies/upstream code
Projects
None yet
Development

No branches or pull requests

2 participants