Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the spec be explicit about deduplicating prefetches/prerenders? #315

Open
kjmcnee opened this issue May 7, 2024 · 3 comments
Open

Comments

@kjmcnee
Copy link
Collaborator

kjmcnee commented May 7, 2024

Spinning off discussion in #310 (comment)

In the chromium implementation, we currently dedupe prefetches and prerenders based on the exact URL. That is, if we have an existing prefetch/prerender to a given URL, we don't start another request to the same URL.

In the prefetch spec, we don't explicitly mention deduplication. In the prerender spec, we explicitly dedupe based on an exact URL match. In either case, the steps are optional, so there's presumably an implicit option for the UA to dedupe.

If we do want to be explicit in the spec about deduplication, should this also incorporate No-Vary-Search?

Options here could be:

  1. Remove the explicit deduplication from this prerender spec
  2. Add explicit deduplication based on exact matches to the prefetch spec
  3. Add explicit deduplication based on NVS matches to the prefetch and prerender specs and update the chromium implementation
  4. Add explicit deduplication based on exact matches to the prefetch spec and add explicitly optional NVS based deduplication to prefetch and prerender specs
@domenic
Copy link
Collaborator

domenic commented May 8, 2024

I am in favor of option 3, unless there is some subtle problem there I am not realizing.

@kjmcnee
Copy link
Collaborator Author

kjmcnee commented May 15, 2024

Option 3 sounds like everyone's preferred option.

It would also allow us to simplify the matching logic to not need to deal with multiple potential matches.

@kjmcnee kjmcnee self-assigned this May 15, 2024
@kjmcnee
Copy link
Collaborator Author

kjmcnee commented Nov 29, 2024

Unassigning myself due to a team change.

@kjmcnee kjmcnee removed their assignment Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants