Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a smaller non-square image size in the Largo Recent Posts widget, and other widgets that have images #1865

Open
3 tasks
benlk opened this issue Jun 15, 2020 · 0 comments
Assignees
Labels
category: feature add New/added features category: performance performance-related issues

Comments

@benlk
Copy link
Collaborator

benlk commented Jun 15, 2020

Largo Recent Posts:

https://github.com/INN/largo/blob/590181982d22a5444eb3c5ccca58ea8b56db12f7/inc/widgets/largo-recent-posts.php#L204-L212

Largo Series Posts:

https://github.com/INN/largo/blob/590181982d22a5444eb3c5ccca58ea8b56db12f7/inc/widgets/largo-series-posts.php#L128-L136

Right now, there are four image sizes:

  • none
  • small 60x60
  • medium 140x140
  • large full

But Largo supports so many more:

https://github.com/INN/largo/blob/590181982d22a5444eb3c5ccca58ea8b56db12f7/functions.php#L262-L268

  • Provide a function that outputs a list of <options>s for each image size registered with Largo/WordPress (whichever is easier) and the associated image sizes (if possible) so that we can use images larger than 140x140 yet smaller than 771px or full.
  • (optional) Ensure that the option values are backwards-compatible with Largo versions prior to this release
  • Include appropriate srcsets in this area, if there's a solution to Apply a filter to the wp_calculate_image_sizes to enable sizes attribute for srcsets #1577. If not, punt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature add New/added features category: performance performance-related issues
Projects
None yet
Development

No branches or pull requests

1 participant