Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Largo Top Term does not handle case where saved top term does not match this post's terms. #1866

Open
benlk opened this issue Jun 26, 2020 · 1 comment
Assignees
Labels
priority: low Nice-to-have in a release. type: bug

Comments

@benlk
Copy link
Collaborator

benlk commented Jun 26, 2020

The top term metabox does not handle this case; it does not check if the saved term ID is in the IDs of the terms on the post or display the assigned top term if that term is not in the list of the post's terms.

https://github.com/INN/largo/blob/590181982d22a5444eb3c5ccca58ea8b56db12f7/inc/post-metaboxes.php#L284-L325

Similarly, the largo_top_term() output function does not check whether the saved term ID is one that applies to the post; we've been assuming that it is.

Initially reported in INN/umbrella-sfpublicpress#109 (comment), where a post had a saved top_term ID that was a term that did not match any of the terms that were assigned to the post.

@benlk benlk added the priority: low Nice-to-have in a release. label Jun 26, 2020
@benlk
Copy link
Collaborator Author

benlk commented Jun 26, 2020

I'm assigning this "priority: low" for now because it's mainly going to be a problem when munging terms, and sites do not often do that.

@joshdarby joshdarby self-assigned this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Nice-to-have in a release. type: bug
Projects
None yet
Development

No branches or pull requests

2 participants