Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M109 does not wait until temperature is reached before returning #41

Open
Wallacoloo opened this issue Oct 25, 2014 · 1 comment
Open
Labels

Comments

@Wallacoloo
Copy link
Owner

M109 Sxxx is supposed to set the temperature to xxx and then wait until that temperature is reached before handling any other commands.

I believe we still want to handle a large class of commands - M105 (get extruder temperature), M20-M32 (SD card access), etc, but just not perform any movements until the temperature is reached.

Unfortunately, implementing it in this way will essentially hang serial communications if given M109 and then a G1 command, until the temperature is reached. This makes it so a host like Octoprint cannot track temperature over time during this period.

This may be fixable by intentionally dropping movement commands during this period, and asking for resends. This gives Octoprint an opportunity to periodically inject M105 commands into the stream.

@Wallacoloo Wallacoloo added the bug label Oct 25, 2014
@Wallacoloo
Copy link
Owner Author

Implemented in devel, but M116 implementation does not handle heated beds or multiple hotends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant