Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop focus doesn't allow keyboard #236

Open
travankor opened this issue Jan 20, 2021 · 2 comments
Open

Drag and drop focus doesn't allow keyboard #236

travankor opened this issue Jan 20, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@travankor
Copy link
Contributor

Describe the bug
Changing focus with drag and drop does not send keyboard input to the view.

To Reproduce
Steps to reproduce the behavior:

  1. Drop a url into a terminal (terminal takes focus)
  2. Type something
  3. Terminal has no input

I also have focus-follow with raise_on_top = false

Expected behavior
If a view is focused after drag and drop, then the view should receive keyboard events.

Wayfire version
0.6.0

@travankor travankor added the bug Something isn't working label Jan 20, 2021
@ammen99
Copy link
Member

ammen99 commented Jan 21, 2021

Probably we need to update cursor focus on drag end, because wlroots holds a grad behind the compositor's back.

ammen99 referenced this issue in WayfireWM/wayfire Apr 16, 2024
Needed to properly fix #1055 in follow-focus.
@ammen99
Copy link
Member

ammen99 commented Apr 16, 2024

This is a bug in follow-focus. It only updates focus on pointer_motion and checks the cursor focus view, but during drag-and-drop and similar operations the cursor focus remains on the old view until the drop event. In general the cursor focus can change on many occasions which is why I am adding a new event in PR WayfireWM/wayfire#2335, but follow-focus will have to be adapted to use that signal.

@ammen99 ammen99 transferred this issue from WayfireWM/wayfire Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants