Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-output tooltip execution spam #265

Open
trigg opened this issue Jul 10, 2024 · 2 comments
Open

Command-output tooltip execution spam #265

trigg opened this issue Jul 10, 2024 · 2 comments

Comments

@trigg
Copy link
Contributor

trigg commented Jul 10, 2024

When a command_output_tooltip_* key is used we get excessive calling of the command on mouseovers.

signal_query_tooltip().connect([=] (int, int, bool,

The signal_query_tooltip callback is called for all mouse movement over the widget.

@NamorNiradnug
Copy link
Collaborator

NamorNiradnug commented Jul 10, 2024

The tooltip's content is updated only once a second though

const auto update_tooltip = [=]
{
if (std::time(nullptr) - last_tooltip_update < 1)
{
return;
}
label_set_from_command(tooltip_command, tooltip_label);
};

@soreau
Copy link
Member

soreau commented Jul 10, 2024

What I'd like to see is, the tooltip updated at $interval while it's open, as the button data is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants