Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically set start time on onset value #33

Open
xavierfav opened this issue Feb 5, 2018 · 3 comments
Open

Automatically set start time on onset value #33

xavierfav opened this issue Feb 5, 2018 · 3 comments
Assignees
@xavierfav
Labels
enhancement

Comments

@xavierfav
Copy link
Member

It would be nice to automatically set the start time of the sampler of each track on the first onset in the corresponding audio clip.
The Freesound API allows to retrieve the onset values, so it is quite simple to implement.
@xavierfav xavierfav changed the title automatically set the start time with onset value Automatically set the start time with onset value Feb 5, 2018
@xavierfav xavierfav changed the title Automatically set the start time with onset value Automatically set the start time on onset value Feb 5, 2018
@xavierfav xavierfav changed the title Automatically set the start time on onset value Automatically set start time on onset value Feb 5, 2018
@xavierfav xavierfav self-assigned this Feb 5, 2018
@xavierfav
Copy link
Member Author

I have tried some stuff using the rhythm.onset_times descriptor given by Freesound API.
It appears that the time does not correspond to the onset we visualise on the printed waveform.
It needs to be more investigated to know where this comes from.

@xavierfav
Copy link
Member Author

It appears that there is a bug under Firefox. The samples loaded have a silence at the beginning of the buffer which make the onset times being not aligned across different browsers.

It would be nice to check if this bug has been previously identified, and see how we could fix it.

@xavierfav xavierfav mentioned this issue Mar 9, 2018
Closed
@xavierfav
Copy link
Member Author

We found out that using ogg files does not bring this issue.
So now we use ogg files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xavierfav xavierfav

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xavierfav