Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll does not occur on overflow #93

Open
WhyFenceCode opened this issue Apr 4, 2024 · 3 comments · Fixed by #100
Open

scroll does not occur on overflow #93

WhyFenceCode opened this issue Apr 4, 2024 · 3 comments · Fixed by #100
Assignees
Labels
area:core A bug/feature for the core code-input.js/code-input.css files bug Something isn't working

Comments

@WhyFenceCode
Copy link

While the scrollbar appears it does not auto scroll and so the cursor goes offscreen. It would be nice to have a plugin to do this, so that the user does not need to manually scroll, and so that the side scroll snaps to the cursor if it goes offscreen.

@WebCoder49
Copy link
Owner

WebCoder49 commented Apr 9, 2024

As this is part of the default functionality of a <textarea> element (I think), this should be implemented in the core code, not as a separate plugin. Thank you for pointing it out!

I am quite busy now but will try to start implementing it as soon as possible after 25 May.

@WebCoder49 WebCoder49 self-assigned this May 25, 2024
@WebCoder49
Copy link
Owner

This occurs on any of these three occasions:

  • Large piece of text pasted onto a line - goes to middle of pasted text. [Regardless of Indent plugin]
  • Indent plugin enabled and Enter key pressed
  • Indent plugin enabled and Tab key pressed

These are replicated in both Chromium [MS Edge 125.0.2535.51 (Official build) (64-bit)] and Firefox [Developer Edition 127.0b5 (64-bit)] on Windows 11. However, in Firefox pressing the Tab key without selecting text will scroll the textarea right, but only this.

@WebCoder49 WebCoder49 linked a pull request May 27, 2024 that will close this issue
@WebCoder49
Copy link
Owner

Fix #100 inadvertently caused bug #115, which makes code-input unusable on mobile devices (note to self: always test on mobile devices!). Another fix is needed that does not blur then focus the textarea, or that does it without interrupting mobile phone typing.

@WebCoder49 WebCoder49 reopened this Jun 16, 2024
@WebCoder49 WebCoder49 added bug Something isn't working area:core A bug/feature for the core code-input.js/code-input.css files labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core A bug/feature for the core code-input.js/code-input.css files bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants