Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: github actions workflow to run on PRs #23

Closed
lenkan opened this issue Sep 5, 2024 · 3 comments
Closed

Proposal: github actions workflow to run on PRs #23

lenkan opened this issue Sep 5, 2024 · 3 comments
Assignees

Comments

@lenkan
Copy link
Contributor

lenkan commented Sep 5, 2024

Suggested checks:

  • Prettier format check
  • Eslint linting
  • Typescript typecheck
  • Vitest test run
@2byrds
Copy link
Collaborator

2byrds commented Sep 5, 2024

@HunnySajid can you add this. It should be similar to the signify-ts checks, see https://github.com/WebOfTrust/signify-ts/blob/main/.github/workflows/main.yml

@HunnySajid
Copy link
Collaborator

@HunnySajid can you add this. It should be similar to the signify-ts checks, see https://github.com/WebOfTrust/signify-ts/blob/main/.github/workflows/main.yml

sure, can you please assign it to me?

@2byrds
Copy link
Collaborator

2byrds commented Sep 11, 2024

Per #20 the workflow can will publish a dev tag to npm on each PR merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants