-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review seqner usage (decimal vs hex) #138
Comments
@rodolfomiranda I encountered this I think. Currently we do |
Keripy definition for numbers from Number:
I think there's a logic error in CesrNumber of signify-ts. It does not match the logic of Number in keripy signify-ts/src/keri/core/number.ts Lines 17 to 23 in 421232d
vs Also there are probably issues using CesrNumber should be fixed. Review code for uses of
|
Review if we are using/calling the seqner correctly in a bunch of places in the code regarding sequence number being decimal or hexadecimal. It'd be helpful to add tests that run over 10 key events.
I assigned the issue to myself as a reminder.
The text was updated successfully, but these errors were encountered: