Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about removing limit of framerate #17

Open
D31F43 opened this issue Mar 6, 2019 · 2 comments
Open

Discussion about removing limit of framerate #17

D31F43 opened this issue Mar 6, 2019 · 2 comments
Assignees

Comments

@D31F43
Copy link
Collaborator

D31F43 commented Mar 6, 2019

This issue relates to #7.

@WenheLI, Do you think it is necessary to refactor our previous design that to limit the frame rate? (I guess in some specific situations, we need high-framerate gif to be recorded.)

We might think of other ways to prevent too much work load of CPU, like to limit the frame count? Or giving an option of the “unsafe mode” to allow these dangerous code?

@WenheLI
Copy link
Owner

WenheLI commented Mar 6, 2019

I think instead of giving a limit on the framerate we should limit the total frames in the RAM to avoid browser crash.

@D31F43
Copy link
Collaborator Author

D31F43 commented Mar 14, 2019

@WenheLI Yeah, that's a great idea. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants