Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong agruments order in mar_logistic.py #42

Closed
2 tasks
shaodaqian opened this issue Aug 12, 2024 · 1 comment
Closed
2 tasks

Wrong agruments order in mar_logistic.py #42

shaodaqian opened this issue Aug 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@shaodaqian
Copy link

1. System Info

PyGrinder version = "0.6.2"

2. Information

  • The official example scripts
  • My own created scripts

3. Reproduction

line 15: def _mar_logistic_torch(
X: Union[np.ndarray, torch.Tensor],
rate_obs: float,
rate_missing: float)

line 125: corrupted_X = _mar_logistic_torch(X, missing_rate, obs_rate)

The order of argument passing is wrong.

4. Expected behavior

Use keyword arguments.

@shaodaqian shaodaqian added the bug Something isn't working label Aug 12, 2024
@WenjieDu
Copy link
Owner

Hi there 👋,

Thank you so much for your attention to PyGrinder and PyPOTS! You can follow me on GitHub to receive the latest news of PyGrinder and PyPOTS. If you find PyGrinder helpful to your work, please star⭐️ this repository. Your star is your recognition, which can help more people notice PyPOTS and grow PyPOTS community. It matters and is definitely a kind of contribution to the community.

I have received your message and will respond ASAP. Thank you for your patience! 😃

Best,
Wenjie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants