From 3625bd1e4e90a15d516fea63fb521456443ee54c Mon Sep 17 00:00:00 2001 From: Wesley Branton Date: Mon, 25 Nov 2019 09:23:43 -0500 Subject: [PATCH 1/4] Fixed error message --- firefox/background.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/firefox/background.js b/firefox/background.js index 7d2dc92..230ccde 100644 --- a/firefox/background.js +++ b/firefox/background.js @@ -108,7 +108,9 @@ function storageChange(changes) { if (changes.volume) { chimeVolume = changes.volume.newValue; - audio.volume = chimeVolume; + if (audio) { + audio.volume = chimeVolume; + } } } From 9f062803e3766e311e6402a323f0037f003bcf9c Mon Sep 17 00:00:00 2001 From: Wesley Branton Date: Mon, 25 Nov 2019 09:23:55 -0500 Subject: [PATCH 2/4] Fixed issue with installation --- firefox/background.js | 1 - 1 file changed, 1 deletion(-) diff --git a/firefox/background.js b/firefox/background.js index 230ccde..87cbe60 100644 --- a/firefox/background.js +++ b/firefox/background.js @@ -116,7 +116,6 @@ function storageChange(changes) { var chimeName, chimeVolume, audio; firstLoad(); -browser.runtime.onInstalled.addListener(handleInstalled); browser.alarms.onAlarm.addListener(hourTrigger); chrome.runtime.onMessage.addListener(listenMessage); browser.storage.onChanged.addListener(storageChange); From c0ddd018161fe1ec7ba28ffa90696cf9c000ad45 Mon Sep 17 00:00:00 2001 From: Wesley Branton Date: Mon, 25 Nov 2019 09:24:04 -0500 Subject: [PATCH 3/4] Fixed options UI --- firefox/options/options.html | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/firefox/options/options.html b/firefox/options/options.html index ebe3cee..59cc69c 100644 --- a/firefox/options/options.html +++ b/firefox/options/options.html @@ -6,9 +6,9 @@ - + - +
@@ -16,6 +16,7 @@
+
+
+
From f73b1e34926b270dc5b4cd21458e81ca562f3c04 Mon Sep 17 00:00:00 2001 From: Wesley Branton Date: Mon, 25 Nov 2019 09:25:36 -0500 Subject: [PATCH 4/4] Increased version --- README.md | 5 +++++ firefox/manifest.json | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 7b6d164..8f61a3c 100644 --- a/README.md +++ b/README.md @@ -18,6 +18,11 @@ To develop and test the extension, you need to open the "about:debugging" page i Further documentation about developing Firefox extensions can be found [here](https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension). ## Release Notes +### Version 1.6.2 +* **[FIXED]** Issue with options UI appearance +* **[FIXED]** Error when changing settings +* **[FIXED]** Error when installing add-on for the first time + ### Version 1.6.1 * **[CHANGE]** Overhauled options UI diff --git a/firefox/manifest.json b/firefox/manifest.json index e7e644e..cb432d0 100644 --- a/firefox/manifest.json +++ b/firefox/manifest.json @@ -1,7 +1,7 @@ { "manifest_version": 2, "name": "Grandfather Fox", - "version": "1.6.1", + "version": "1.6.2", "description": "Turn Firefox into a grandfather clock that plays a tune at the top of each hour!", "icons": {