Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILDING.md and related build tools/scripts fail to work #771

Open
realchrisolin opened this issue Jul 15, 2023 · 2 comments
Open

BUILDING.md and related build tools/scripts fail to work #771

realchrisolin opened this issue Jul 15, 2023 · 2 comments
Labels
Documentation Visual Studio This is an issue with building or Visual Studio.

Comments

@realchrisolin
Copy link

Describe the bug
Current build instructions and related scripts/tools are not functioning successfully

To Reproduce
Steps to reproduce the behavior:

  1. Follow build instructions described in https://github.com/WhitewaterFoundry/Pengwin/blob/master/BUILDING.md
  2. Check out the latest stable release of Pengwin (e.g. 22.11.4)
  3. Run the build scripts described in BUILDING.md from a Debian WSL environment on Windows 11 with VS2017 Community installed with various required workloads/SDKs installed

Expected behavior
Build instructions work successfully as written

Additional context
I'm a long time Pengwin user from back when it was called WLinux. Basically, I want to run Pengwin on an employer-owned computer without logging into my personal Microsoft Store account nor pay an additional $20 for the privilege of an easy installation. That said, since Pengwin is open source, there's no reason I can't build it for free instead (right?). While I was able to eventually build a successful x64 release MSIXBUNDLE after many hours of troubleshooting and making several modifications to various scripts/files to get a working build environment.

For example, the https://github.com/WhitewaterFoundry/legacy-rootfs-build-scripts/blob/master/pengwin-create-targz.sh script fails immediately if additional commands to create the /tmp directory and 'testing' subdirectory aren't included. Next, this repository that I'm filing this issue against already has a ./linux_files directory needed for the create-targz script to run, but line 22 of https://github.com/WhitewaterFoundry/legacy-rootfs-build-scripts/blob/master/pengwin-create-targz.sh#L22 expects the directory name to be "pengwin_linux_files". Additionally, the apt-get autoremove/remove lines throws a dependency error related to systemd which causes the shell script to fail. Similarly related, the curl lines in https://github.com/WhitewaterFoundry/Pengwin/blob/master/linux_files/setup#L37 lines 37 and 38 fail with the $1 substitution in the URL string. This same bug is present in https://github.com/WhitewaterFoundry/legacy-rootfs-build-scripts/blob/master/pengwin_linux_files/setup.

I will be following up with a pull request meant to resolve these issues and other related issues that I haven't yet described in a couple of days with proposed changes to multiple files with an explanation of the issues/errors they are meant to fix or work around. All my research into the exact error messages I received and my code changes related to this issue is on an employer-owned computer that I won't have access to over the weekend.

@realchrisolin realchrisolin added the Bug This is a problem. label Jul 15, 2023
@crramirez
Copy link
Collaborator

Hello @realchrisolin

Thank you very much for your contribution. As you noticed BUILDING.md is 4 years old. This is one of the many things to do that have accumulated over the years along with documentation and other fixes.

The repo mentioned there is wrong, also 4 years old. It won't create a good distro. Use the scripts inside https://github.com/WhitewaterFoundry/pengwin-rootfs-builds instead

@realchrisolin
Copy link
Author

Greetings @crramirez

As you noticed BUILDING.md is 4 years old.

Actually, I didn't (but that explains a few things). I will detail individual fixes and exact commands I came up with to get it to build for me in the pull request I open later today or tomorrow and see if you have any input.

I initially built the latest stable release in GitHub from source, but then noticed you pushed 23.07 upstream without checking out a new version in GH and used the opportunity to clean up exact fixes/command changes. Even the rootfs-build script has issues.

@crramirez crramirez added Visual Studio This is an issue with building or Visual Studio. Documentation and removed Bug This is a problem. labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Visual Studio This is an issue with building or Visual Studio.
Projects
None yet
Development

No branches or pull requests

2 participants