Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split WireMock into multiple nuget packages depending on features #1071

Open
asidorowicz opened this issue Feb 26, 2024 · 5 comments · May be fixed by #1072
Open

Split WireMock into multiple nuget packages depending on features #1071

asidorowicz opened this issue Feb 26, 2024 · 5 comments · May be fixed by #1072
Assignees
@StefH
Labels
feature

Comments

@asidorowicz
Copy link

Is your feature request related to a problem? Please describe.
WireMock is currently a single monolithic dependency that pulls with it a very large amount of transitive dependencies, regardless of whether the features are used or not. This can be seen as a minor inconvenience, but enough for our team to have decided to use a different testing tool.

Describe the solution you'd like
Split WireMock into separate dependencies depending on desired features, especially if the features require large transitive dependencies (eg: Graphql)

Describe alternatives you've considered
We have tried to exclude non-used transitive dependencies, but it is a clunky solution.
@StefH StefH self-assigned this Feb 26, 2024
@StefH
Copy link
Collaborator

StefH commented Feb 26, 2024

@asidorowicz
Good point. I'll think on this...

@StefH
Copy link
Collaborator

StefH commented Feb 26, 2024

Work in progress... : #1072

@StefH
Copy link
Collaborator

StefH commented Feb 26, 2024

@asidorowicz
If you have time, you can test preview version 1.5.48-ci-18384 which has separate NuGet for GraphQL, ProtoBuf and MimeKitLite.

https://github.com/WireMock-Net/WireMock.Net/wiki/MyGet-preview-versions

@asidorowicz
Copy link
Author

@StefH
Thank you for your work! I didn't expect such a quick response :)
It is much better, though there are still many dependencies that I don't know whether they are part of the core functionality or could be add-ons.
Either way, I believe it is an awesome step into a modular approach!

@StefH
Copy link
Collaborator

StefH commented Mar 2, 2024

@asidorowicz
I'll check if more packages can be extracted, however after some thinking, I want to take a slightly different approach.

  • I want to keep the WireMock.Net NuGet the same, to avoid backwards compatibility issues.
  • I'll create a new NuGet WireMock.Net.Minimal which excludes these extra packages.

@StefH StefH linked a pull request Mar 5, 2024 that will close this issue
Create new projects: WireMock.Net.Minimal, WireMock.Net.Shared, WireMock.Net.GraphQL, WireMock.Net.MimePart and WireMock.Net.ProtoBuf #1072
Open
@StefH StefH mentioned this issue Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefH StefH

Labels
feature
Projects
None yet
Milestone
No milestone
2 participants
@StefH @asidorowicz