Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Leave option is not connected #97

Open
YannickLimmer opened this issue Mar 20, 2024 · 2 comments
Open

[BUG] Leave option is not connected #97

YannickLimmer opened this issue Mar 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@YannickLimmer
Copy link

Describe the bug

The leave option of the stqdm progress bar should have an effect not only for the inherited tqdm. The change below should fix this.

Current:

   def close(self):
        super().close()
        self.st_clear()

Proposed change:

   def close(self):
        super().close()
        if self.leave is False:  #  <-- Check if leave is desired
            self.st_clear()
@YannickLimmer YannickLimmer added the bug Something isn't working label Mar 20, 2024
@Wirg
Copy link
Owner

Wirg commented Mar 28, 2024

Hi @YannickLimmer ,

Thanks for reporting. I will be looking into that. :)
I have a bunch of changes to integrate, I am going to try a release next week and will probably integrate this.

@joeleeyk
Copy link

Hi @Wirg ,

I can see the "leave" changes in the github repo, but they are not in pypi yet. Just commenting in case this is not intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants