Misleading error messages when passing an incorrect schema in serialize().

[Hanaasagi]

My Env

• better-sqlite3: 9.0.0
• Linux 6.5.7-arch1-1 x86_64 unknown
• sqlite3: 3.43.2 2023-10-10 12:14:04 4310099cce5a487035fa535dd3002c59ac7f1d1bec68d7cf317fd3e76948alt1 (64-bit)

Repro

import Database from "better-sqlite3";

const db = new Database(":memory:");
// Out of memory
db.serialize({ attached: "foobar" });
// work as expected
// db.serialize({ attached: "main" });

What I see

/home/********/node_modules/better-sqlite3/lib/methods/serialize.js:15
        return this[cppdb].serialize(attachedName);
                           ^

Error: Out of memory

Expected behavior

some error like schema not found.

[Prinzhorn]

Yep, seems like this does not account for this case:

better-sqlite3/src/objects/database.lzz

Lines 285 to 290 in 007d43e

	unsigned char* data = sqlite3_serialize(db->db_handle, *attached_name, &length, 0);
	if (!data && length) {
	ThrowError("Out of memory");
	return;
	}

So maybe the error message could be updated to be more generic.

some error like schema not found.

sqlite3_serialize does not provide this information and it does not seem to be trivial to get it (ChatGTP suggests parsing the result of PRAGMA database_list;)