Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Refactor/dedup agent tests #223

Open
a-martynovich opened this issue Sep 25, 2019 · 2 comments
Open

Refactor/dedup agent tests #223

a-martynovich opened this issue Sep 25, 2019 · 2 comments
Labels
story-points-unknown Unknown Story Points

Comments

@a-martynovich
Copy link
Contributor

a-martynovich commented Sep 25, 2019 •
edited
Loading

Lots of tests need to mock/patch lots of things. Mocking/patching takes more lines of code than the actual test, and it duplicates in every test. This should be refactored in order to improve readability and simplify addition of new tests.
@a-martynovich
Copy link
Contributor Author

@vpetersson As I said before, this task has a wrong description. Tests don't send pings to the server. I suggested we call this task "refactor agent tests" and it will be about deduping/refactoring agent's tests.

@a-martynovich a-martynovich changed the title Some tests may send actual pings to the server. Refactor/dedup agent tests Nov 25, 2019
@vpetersson
Copy link
Contributor

Ok, let's put this in the general backlog if you're confident CI doesn't send tests to the backend.

@vpetersson vpetersson added the story-points-unknown Unknown Story Points label Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
story-points-unknown Unknown Story Points
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vpetersson @a-martynovich