From 627a5d3285ddf285577b15686c0f9d0f2b6473a5 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Tue, 12 Dec 2023 00:18:42 +0100 Subject: [PATCH] Core: remove an exclusion Turns out the exclusion is a little too aggresive. The `Generic.WhiteSpace.LanguageConstructSpacing` _will_ throw an error when there is too much whitespace, but not when there is no whitespace and the next thing is an open parenthesis. By removing the exclusion, an error will now (correctly) be thrown when there is no whitespace between a closure `use` keyword and the open parenthesis. It also means that where there is _too much_ whitespace between the keyword and the open parenthesis, two errors will be thrown, one from the `Generic.WhiteSpace.LanguageConstructSpacing` sniff and one from the `Squiz.Functions.MultiLineFunctionDeclaration` sniff. Well, so be it. As both sniffs expect the same thing, this shouldn't lead to fixer conflicts anyhow. See https://github.com/WordPress/WordPress-Coding-Standards/issues/764#issuecomment-1851046232 --- WordPress-Core/ruleset.xml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/WordPress-Core/ruleset.xml b/WordPress-Core/ruleset.xml index 8671caef5..12c928bf4 100644 --- a/WordPress-Core/ruleset.xml +++ b/WordPress-Core/ruleset.xml @@ -218,10 +218,6 @@ 0 - - - 0 -