Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for link add/edit/remove audible feedback #11006

Open
tofumatt opened this issue Oct 24, 2018 · 2 comments
Open

Write tests for link add/edit/remove audible feedback #11006

tofumatt opened this issue Oct 24, 2018 · 2 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Decision Needs a decision to be actionable or relevant [Package] Format library /packages/format-library [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Comments

@tofumatt
Copy link
Member

We should add tests for #10795 to make sure the link speech commands are working as intended and not regressing, as it might be easy to miss in regular usage.

The patch was an easy win but @iseulde pointed out I should have asked for tests, so I'm assigning myself to write them as penance 😆

If anyone else wants to though feel free and I'll review them! 😉
@tofumatt tofumatt added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Oct 24, 2018
@tofumatt tofumatt self-assigned this Oct 24, 2018
@tofumatt tofumatt mentioned this issue Oct 24, 2018
Merged
4 tasks
@ellatrix ellatrix added [Package] Format library /packages/format-library and removed [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Jan 29, 2019
@gziolo gziolo added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Apr 23, 2019
@gziolo
Copy link
Member

gziolo commented Apr 23, 2019

I doesn't look like @tofumatt is actively working on it. This one needs a developer :)

@aduth aduth added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Feb 10, 2020
@Mamaduka
Copy link
Member

Can we close this? The last activity was four years ago. The link format is stable, and I've not seen any reports of audible feedback regressing.

@Mamaduka Mamaduka added Needs Decision Needs a decision to be actionable or relevant and removed Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Decision Needs a decision to be actionable or relevant [Package] Format library /packages/format-library [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tofumatt @Mamaduka @gziolo @aduth @ellatrix