Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Handle block menu items when creating a Navigation block from a menu #24675

Closed
noisysocks opened this issue Aug 20, 2020 · 0 comments · Fixed by #24846
Closed

Navigation: Handle block menu items when creating a Navigation block from a menu #24675

noisysocks opened this issue Aug 20, 2020 · 0 comments · Fixed by #24846
Assignees
@noisysocks
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

If you have a menu item with type = 'block', creating a Navigation block from that menu won't properly handle the block menu item.

block-menu-item

Steps to reproduce

  1. Add a Search block to a menu using the Navigation screen. See Navigation screen: Add opt-in Navigation block rendering #24503 for instructions.
  2. Save the menu.
  3. Go to a post and insert a Navigation block.
  4. Select the menu and click Create.

Expected behaviour

The Navigation block appears exactly as it does in the Navigation screen.

Actual behaviour

The Search block is turned into a Link block with its title set to "Block".
@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Aug 20, 2020
@noisysocks noisysocks self-assigned this Aug 20, 2020
@noisysocks noisysocks mentioned this issue Aug 27, 2020
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisysocks noisysocks

Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Navigation: Handle block menu items WordPress/gutenberg
1 participant
@noisysocks