Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README for TextAlignmentControl component #68126

Merged

Conversation

im3dabasia
Copy link
Contributor

Part of: #22891
Follow up: #67371

What?

This PR adds a README for the TextAlignmentControl component.

@im3dabasia im3dabasia requested a review from ellatrix as a code owner December 19, 2024 09:02
Copy link

github-actions bot commented Dec 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia
Copy link
Contributor Author

Hey @t-hamano, could you please review this PR when you have a moment?

Thanks! 🙇

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

You probably looked at the README for the TextDecorationControl component, but I noticed that the heading levels are incorrect.

The correct format should be as follows.

If there is the developer guidelines:

# ComponentName

## Development guidelines

### Usage

### Props

#### prop

If there is no developer guidelines:

# ComponentName

## Usage

## Props

### prop

I think there is no developer guidelines for this component, so could you use the latter format and correct the heading levels?

@im3dabasia
Copy link
Contributor Author

Hi @t-hamano,

I’ve removed the justify option as it wasn’t present by default, and I’ve also corrected the headings to use the appropriate # levels.

Could you please review the PR again and share your feedback?

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Could you make one last change?

@im3dabasia
Copy link
Contributor Author

Hey @t-hamano , Thank you very much for the follow up. I have made the requested changes please check.

@im3dabasia im3dabasia requested a review from t-hamano December 25, 2024 16:03
@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Dec 26, 2024
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit 61d7404 into WordPress:trunk Dec 26, 2024
66 of 67 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants