-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README for TextAlignmentControl component #68126
Add README for TextAlignmentControl component #68126
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hey @t-hamano, could you please review this PR when you have a moment? Thanks! 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
You probably looked at the README for the TextDecorationControl
component, but I noticed that the heading levels are incorrect.
The correct format should be as follows.
If there is the developer guidelines:
# ComponentName
## Development guidelines
### Usage
### Props
#### prop
If there is no developer guidelines:
# ComponentName
## Usage
## Props
### prop
I think there is no developer guidelines for this component, so could you use the latter format and correct the heading levels?
packages/block-editor/src/components/text-alignment-control/README.md
Outdated
Show resolved
Hide resolved
Hi @t-hamano, I’ve removed the justify option as it wasn’t present by default, and I’ve also corrected the headings to use the appropriate # levels. Could you please review the PR again and share your feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Could you make one last change?
packages/block-editor/src/components/text-alignment-control/README.md
Outdated
Show resolved
Hide resolved
Hey @t-hamano , Thank you very much for the follow up. I have made the requested changes please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Part of: #22891
Follow up: #67371
What?
This PR adds a README for the TextAlignmentControl component.