Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin version of audiowaveform image in API Dockerfile #3782

Closed
dhruvkb opened this issue Feb 10, 2024 · 1 comment · Fixed by #3784
Closed

Pin version of audiowaveform image in API Dockerfile #3782

dhruvkb opened this issue Feb 10, 2024 · 1 comment · Fixed by #3784
Assignees
@zablon-oigo
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API 🐳 tech: docker Involves Docker

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Feb 10, 2024

Problem

The current API Dockerfile uses the latest tag of the audiowaveform image.

openverse/api/Dockerfile

Line 10 in e98f7e9

FROM docker.io/realies/audiowaveform:latest AS awf

Description

As @realies has pointed out in #2412, now the workflow tags the images with a version, when a new version of bbc/audiowaveform is published with a Git tag.

That line can now be updated as follows.

- FROM docker.io/realies/audiowaveform:latest AS awf
+ FROM docker.io/realies/audiowaveform:1.10.1 AS awf
@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🐳 tech: docker Involves Docker 🧱 stack: api Related to the Django API labels Feb 10, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Feb 10, 2024
@zablon-oigo
Copy link
Contributor

Hello, I'm interested in addressing this issue. Could you please assign it to me? I believe I can handle it effectively.
Thank you!

@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Feb 10, 2024
@zablon-oigo zablon-oigo mentioned this issue Feb 11, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Feb 12, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zablon-oigo zablon-oigo

Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API 🐳 tech: docker Involves Docker
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Updated Dockerfile to Use Specific Version of audiowaveform Image
2 participants
@dhruvkb @zablon-oigo