Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to audio works to use "audio track(s)" #3972

Closed
sarayourfriend opened this issue Mar 26, 2024 · 2 comments
Closed

Update references to audio works to use "audio track(s)" #3972

sarayourfriend opened this issue Mar 26, 2024 · 2 comments
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Mar 26, 2024

Problem

In #3941 we established a convention of referring to audio works/results as "audio tracks" rather than just "audio". While "audio" is indeed a singular and plural noun, it has a strange feeling as a noun. Using the phrase "audio tracks" reads better.

Description

Update existing references to audio works to use the new convention "audio track(s)".

Additional information

All of the English text in Openverse is contained in en.json5:

https://github.com/WordPress/openverse/blob/aa9ea4bcfe40683923c98ca43b23f6ff22a06a2f/frontend/src/locales/scripts/en.json5

To fix this issue, you would need to find occurrences of "audio" that refers to "audio tracks", and replace it with "audio track".
Here, we would replace audio with audio track:
{hero: { description: "An extensive library of free stock photos, images, and audio, available for free use." } }
But here, replacement is not needed:
"This audio format is not supported by your browser."

@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: frontend Related to the Nuxt frontend labels Mar 26, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Mar 26, 2024
@krysal krysal added good first issue New-contributor friendly help wanted Open to participation from the community labels Mar 29, 2024
@Collins-Webdev
Copy link
Contributor

Hello @sarayourfriend ,
I made a pull request about it here.

Please review the changes and let me know if there are any further adjustments needed. Thank you for considering my contribution.

@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Apr 4, 2024
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Apr 4, 2024
@obulat
Copy link
Contributor

obulat commented Jun 4, 2024

Fixed in #4037

@obulat obulat closed this as completed Jun 4, 2024
@obulat obulat moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

No branches or pull requests

4 participants