Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests causing 500 errors when verifying OAuth application registration do not have errors logged #4893

Open
sarayourfriend opened this issue Sep 9, 2024 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API

Comments

@sarayourfriend
Copy link
Collaborator

Description

Some OAuth application verification requests end in 500 responses, but there are no matching logs with stack traces or any information to debug these errors and fix them.

image

The fact that multiple requests were sent for the same verification token (redacted in the screenshot above, but it's all one verification token) might be a clue.

Reproduction

No idea how to reproduce. We need to look at the code and see if there are things swallowing errors without logging or making these invisible in logs. We might need to add speculative logs if we can't find anything in the code that we think is causing this.

Additional context

Prioritised as high because these errors have no information other than they are a server-crashing error... which means there isn't anything to go off of to say they aren't "high" or "critical" except for that they are rare (which could be an accident of obscurity than actually a difficult-to-cause edge case).

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Sep 9, 2024
@obulat obulat moved this to 📅 To Do in Openverse Backlog Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Status: 📅 To Do
Development

No branches or pull requests

1 participant