Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Test RTL, Japanese, Chinese, and Korean #312

Open
carolinan opened this issue Sep 14, 2024 · 6 comments
Open

Task: Test RTL, Japanese, Chinese, and Korean #312

carolinan opened this issue Sep 14, 2024 · 6 comments
Labels
Help Wanted Extra attention is needed Internationalization (i18n) Issues or PRs related to internationalization efforts Task

Comments

@carolinan
Copy link
Contributor

carolinan commented Sep 14, 2024

Step-by-step reproduction instructions
Look for and report problems that are obvious issues.

Create new pages and posts.
Add both smaller patterns, full width patterns, and the different templates.
Try the menus.

Templates are changed by going to Appearance > Editor > Templates, selecting the template type, and changing the pattern in the Design panel in the settings sidebar.

Make sure to test the "right-aligned blog" designs with the vertical header.

@carolinan carolinan added [Status] Blocked Used to indicate that a current effort isn't able to move forward Task Contributor day and removed [Status] Blocked Used to indicate that a current effort isn't able to move forward labels Sep 14, 2024
@carolinan carolinan added Help Wanted Extra attention is needed Internationalization (i18n) Issues or PRs related to internationalization efforts and removed Contributor day labels Sep 25, 2024
@carolinan
Copy link
Contributor Author

carolinan commented Sep 27, 2024

Potential issues:

The link post format pattern has an arrow icon that I believe is pointing in the wrong direction on RTL? I don't know if it is solvable.

link post format with a text, a custom link, and an arrow icon

@juanfra
Copy link
Member

juanfra commented Sep 27, 2024

I just asked a friend who's native in Hebrew (and a theme designer) and she told me that ideally it should point to the left.

@juanfra
Copy link
Member

juanfra commented Sep 27, 2024

Removed the icon, for now. And we can revisit later to see if we find an elegant solution for it.

@beafialho
Copy link
Contributor

@carolinan I've tried changing the site language but the patterns and templates are showing up in English, is this expected or am I missing a step?

@juanfra
Copy link
Member

juanfra commented Oct 10, 2024

@beafialho the patterns will still be shown in English as the contents have yet to be translated to other languages, but the text orientation should change.

@beafialho
Copy link
Contributor

Ok, I also assumed they have yet to be translated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed Internationalization (i18n) Issues or PRs related to internationalization efforts Task
Projects
None yet
Development

No branches or pull requests

3 participants